-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for projects that do not enable global usings. #518
Merged
mwadams
merged 2 commits into
main
from
feature/514-generated-code-should-include-all-required-using-statements
Dec 17, 2024
Merged
Added support for projects that do not enable global usings. #518
mwadams
merged 2 commits into
main
from
feature/514-generated-code-should-include-all-required-using-statements
Dec 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mwadams
commented
Dec 17, 2024
- Added new --addExplciitUsings command line switch
- Added the corresponding option to the generator config
- Added a Sandbox.NoGlobalUsings test project
Code Coverage Summary Report - Linux (net8.0)Summary
CoverageCorvus.Json.CodeGeneration - 77.2%
Corvus.Json.CodeGeneration.201909 - 87.3%
Corvus.Json.CodeGeneration.202012 - 86.8%
Corvus.Json.CodeGeneration.4 - 86.8%
Corvus.Json.CodeGeneration.6 - 87.6%
Corvus.Json.CodeGeneration.7 - 89%
Corvus.Json.CodeGeneration.CSharp - 89.9%
Corvus.Json.CodeGeneration.OpenApi30 - 85.9%
Corvus.Json.ExtendedTypes - 60.6%
Corvus.Json.JsonReference - 61.5%
Corvus.Json.Patch - 19.6%
Corvus.Json.Specs - 58.1%
|
Test Results0 tests ±0 0 ✅ ±0 0s ⏱️ ±0s For more details on these parsing errors, see this check. Results for commit 9343d5a. ± Comparison against base commit 4a6034e. ♻️ This comment has been updated with latest results. |
Code Coverage Summary Report - Windows (net8.0)Summary
CoverageCorvus.Json.CodeGeneration - 77.2%
Corvus.Json.CodeGeneration.201909 - 87.3%
Corvus.Json.CodeGeneration.202012 - 86.8%
Corvus.Json.CodeGeneration.4 - 86.8%
Corvus.Json.CodeGeneration.6 - 87.6%
Corvus.Json.CodeGeneration.7 - 89%
Corvus.Json.CodeGeneration.CSharp - 89.9%
Corvus.Json.CodeGeneration.OpenApi30 - 85.9%
Corvus.Json.ExtendedTypes - 60.6%
Corvus.Json.JsonReference - 65.8%
Corvus.Json.Patch - 19.6%
Corvus.Json.Specs - 58.1%
|
Code Coverage Summary Report - Windows (net481)Summary
CoverageCorvus.Json.CodeGeneration - 79.4%
Corvus.Json.CodeGeneration.201909 - 87.3%
Corvus.Json.CodeGeneration.202012 - 86.8%
Corvus.Json.CodeGeneration.4 - 86.8%
Corvus.Json.CodeGeneration.6 - 87.6%
Corvus.Json.CodeGeneration.7 - 89%
Corvus.Json.CodeGeneration.CSharp - 89.8%
Corvus.Json.CodeGeneration.OpenApi30 - 85.9%
Corvus.Json.ExtendedTypes - 65%
Corvus.Json.JsonReference - 63.5%
Corvus.Json.Patch - 21.3%
Corvus.Json.Specs - 59.1%
IndexRange - 28%
|
mwadams
deleted the
feature/514-generated-code-should-include-all-required-using-statements
branch
December 17, 2024 10:03
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.